chore(vm): optimize code style#6552
Open
anderson09-geek wants to merge 1 commit intotronprotocol:developfrom
Open
chore(vm): optimize code style#6552anderson09-geek wants to merge 1 commit intotronprotocol:developfrom
anderson09-geek wants to merge 1 commit intotronprotocol:developfrom
Conversation
bladehan1
reviewed
Mar 2, 2026
| DataWord amountArrayOffset = stack.get(stack.size() - 2); | ||
| DataWord witnessArrayLength = stack.get(stack.size() - 3).clone(); | ||
| DataWord witnessArrayOffset = stack.get(stack.size() - 4); | ||
| BigInteger amountArrayLength = stack.get(stack.size() - 1).value(); |
Contributor
There was a problem hiding this comment.
Why it was changed from DataWord to BigInteger;
And the PR title doesn't match the code format modifications, so relevant details should be supplemented.
warku123
reviewed
Mar 2, 2026
| DataWord amountArrayOffset = stack.get(stack.size() - 2); | ||
| DataWord witnessArrayLength = stack.get(stack.size() - 3).clone(); | ||
| DataWord witnessArrayOffset = stack.get(stack.size() - 4); | ||
| BigInteger amountArrayLength = stack.get(stack.size() - 1).value(); |
There was a problem hiding this comment.
Inlining memNeeded() is fine for readability, but can you confirm it didn't contain any boundary checks we're now missing. Also, verify that BigInteger produces identical results to DataWord for edge cases (very large value), since their overflow behavior differs.
I also think this PR need more relavant details for review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why are these changes required?
This PR has been tested by:
Follow up
Extra details